-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQL Server - sqlServerRingBufferCPU - removed whitespaces #9130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla
!signed-cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤝 ✅ CLA has been signed. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like new artifacts were built from this PR. Get them here!
Artifact URLs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fair enough
@sspaink can you have a look at this and eventually merge it? |
### Required for all PRs: - [ ] Updated associated README.md. - [ ] Wrote appropriate unit tests. Removed a pair of whitespace chars from the **sqlServerRingBufferCPU** SQL statement and added some formatting. This query exists only for the on-prem version of SQL Server (`database_type = "SQLServer"`) If you were unlucky enough to have some SQL 2008 the query wouldn't work as the whitespace char is not allowed inside the statement. (cherry picked from commit 8b9883e)
…#9130) ### Required for all PRs: - [ ] Updated associated README.md. - [ ] Wrote appropriate unit tests. Removed a pair of whitespace chars from the **sqlServerRingBufferCPU** SQL statement and added some formatting. This query exists only for the on-prem version of SQL Server (`database_type = "SQLServer"`) If you were unlucky enough to have some SQL 2008 the query wouldn't work as the whitespace char is not allowed inside the statement. (cherry picked from commit 8b9883e)
Required for all PRs:
Removed a pair of whitespace chars from the sqlServerRingBufferCPU SQL statement and added some formatting.
This query exists only for the on-prem version of SQL Server (
database_type = "SQLServer"
)If you were unlucky enough to have some SQL 2008 the query wouldn't work as the whitespace char is not allowed inside the statement.