Delete log.Fatal calls and replace with error returns. #9086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sspaink
reviewed
Apr 5, 2021
sspaink
approved these changes
Apr 6, 2021
ssoroka
approved these changes
Apr 6, 2021
jblesener
pushed a commit
to jblesener/telegraf
that referenced
this pull request
Apr 18, 2021
* Delete log.Fatal calls and replace with error returns. * Update opcua_util.go * Update opcua_util.go
reimda
pushed a commit
that referenced
this pull request
Apr 28, 2021
* Delete log.Fatal calls and replace with error returns. * Update opcua_util.go * Update opcua_util.go (cherry picked from commit ef2def2)
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
* Delete log.Fatal calls and replace with error returns. * Update opcua_util.go * Update opcua_util.go (cherry picked from commit ef2def2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing all calls other than in tests. Calls to metric.new have no chance of returning an error, so we can ignore it (it's a mistake that it returns an 'error', and could be refactored soon)