Add ~200 more Couchbase metrics via Buckets endpoint #9032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we may want to consider adding |
Done |
2623078 to
a8c1c91
Compare
ssoroka
approved these changes
Mar 29, 2021
I guess my thinking was that if the user is handpicking every field they do want, they won't have much of a need for fields excluded? |
|
It depends. if you want all fields except 1 or 2, but you also want to get any fields added from plugin updates, exclude would be a better fit. I'm not certain it matters that much for this, but that's the idea. |
jblesener
pushed a commit
to jblesener/telegraf
that referenced
this pull request
Apr 18, 2021
* Couchbase new metrics for buckets * updated * update to simplify two different modes. * cleanup code * linter telling me to fix things I didn't do * add include/exclude filter * update sample config * appease the linter * Update README.md * make all metrics configurable, defaults as just 'basic bucket metrics' * check error in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The additional metrics are configurable as
detailedmetrics.Many of the stats being added correlate directly to graphs available on the Couchbase UI, you can hover them to see their metric 'name'.
Every gather of the
detailedmetrics will gather the latest Couchbase metrics (from the last possible second).resolves #4152