feat: Supervisord input plugin #9015

niasar · 2021-03-18T16:25:17Z

Hello, I've seen some interest(#5126) in adding input plugin for monitoring processes, that running under supervisord plus maybe supervisord itself and I am interested in it as well. Unit and integration tests are included.

Required for all PRs:

Associated README.md updated.
Has appropriate unit tests.

telegraf-tiger

🤝 ✅ CLA has been signed. Thank you!

Updating to 1.18

…upervisor

sjwang90 · 2021-09-20T19:21:41Z

Hi @niasar! Thanks for the PR! Could you resolve the conflicts so we can get this reviewed?

niasar · 2021-09-23T10:58:26Z

Hi @niasar! Thanks for the PR! Could you resolve the conflicts so we can get this reviewed?

Hey, thank you for showing interest. I'll try to do it at this or next weekend.

# Conflicts: # docs/LICENSE_OF_DEPENDENCIES.md # go.mod

telegraf-tiger · 2021-09-25T07:21:54Z

Looks like new artifacts were built from this PR. Get them here!

Artifact URLs

niasar · 2021-09-25T07:25:29Z

@sjwang90 Done

powersj

Hi! This showed up in my list of things to look through today. It looks like it has sat for a while, but I still wanted to give it a review. At a high level, I appreciate that you took the time to write this and include not only unit tests, but an integration test.

I have added a few comments and one big question around username/password. Before I dive into the code, I wanted to see your thoughts on that area first and if you were still interested in looking through this.

Thanks!

plugins/inputs/supervisor/README.md

README.md

docker-compose.yml

plugins/inputs/supervisor/README.md

… disable basic auth. Added details about using plugin with authentication enabled.

telegraf-tiger · 2021-10-09T20:22:55Z

📦 Looks like new artifacts were built from this PR.

Expand this list to get them here! 🐯

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	freebsd_amd64.tar.gz	windows_i386.zip
armel.deb	armv6hl.rpm	freebsd_armv7.tar.gz
armhf.deb	linux_i386.tar.gzi386.rpm	freebsd_i386.tar.gz
i386.deb	ppc64le.rpm	linux_amd64.tar.gz
mips.deb	s390x.rpm	linux_arm64.tar.gz
mipsel.deb	x86_64.rpm	linux_armel.tar.gz
ppc64el.deb		linux_armhf.tar.gz
s390x.deb		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_s390x.tar.gz
		static_linux_amd64.tar.gz

lcgogo · 2021-12-28T07:20:32Z

when will this PR be merged? @niasar

sjwang90 · 2022-01-04T16:02:37Z

@niasar Can you edit the title of the pull request to feat: Supervisord input plugin so it passes the Semantic Pull Request check?

powersj · 2022-01-04T16:16:49Z

Additionally please rebase on master to resolve the conflict on go.mod

@srebhan would be a good one for you to quickly look over :)

srebhan

@niasar the code looks quite good already, however I have some comments... :-/ It's mostly minor things.

@powersj I'm not sure about the location of the Dockerfile and friend, so it would be nice to get your or @reimda's feedback.

plugins/inputs/supervisor/README.md

plugins/inputs/supervisor/supervisor.go

plugins/inputs/supervisor/supervisor_test.go

powersj · 2022-07-25T18:52:54Z

Hi,

@niasar wanted to check in and see if you were planning any further updates!

Thanks!

reimda · 2022-07-26T20:13:14Z

Since this already has one review approval and is only waiting on small docs change requests from me, if @niasar doesn't come back I think we should complete it instead of closing due to inactivity.

niasar · 2022-07-27T17:36:02Z

Hello and sorry for absence. As I'm now moved to a new place, i had shortage of free time for a few months. I'll be ready to get back to work in the beginning of next week.

niasar · 2022-08-02T11:52:09Z

Could we make a few changes to the wording of the documentation? Also I think using a string instead of a boolean for the use_identification_tag setting would work better. What do you think?

Thanks for feedback, i'll look in your suggestions later, for now i'm going to merge latest master branch and make integration tests using testutil.container.

…iners

srebhan · 2022-08-02T18:28:49Z

Hey @niasar, thanks for your effort! It seems like the license file needs one line removed to make the tests happy. You can run make check-deps locally to see what needs to be done... Can you please fix this?

srebhan · 2022-08-03T18:41:00Z

And another conflict @niasar. Let me know if you cannot find time and I can resolve this for you...

plugins/inputs/supervisor/supervisor.go

plugins/inputs/supervisor/README.md

telegraf-tiger · 2022-08-06T12:12:06Z

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	darwin_arm64.tar.gz	windows_i386.zip
armel.deb	armv6hl.rpm	freebsd_amd64.tar.gz
armhf.deb	i386.rpm	freebsd_armv7.tar.gz
i386.deb	ppc64le.rpm	freebsd_i386.tar.gz
mips.deb	riscv64.rpm	linux_amd64.tar.gz
mipsel.deb	s390x.rpm	linux_arm64.tar.gz
ppc64el.deb	x86_64.rpm	linux_armel.tar.gz
riscv64.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_riscv64.tar.gz
		linux_s390x.tar.gz
		static_linux_amd64.tar.gz

powersj

Thanks for finishing this up!

Can I please ask you to put a README on your dockerhub page? Something that lays out 1) the port used and 2) where the configuration file exists?

First version of supervisord input plugin with tests included

dbb5311

telegraf-tiger bot approved these changes Mar 18, 2021

View reviewed changes

telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin new plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Mar 18, 2021

niasar and others added 7 commits March 18, 2021 19:33

Merge pull request #1 from influxdata/master

0bd2875

Updating to 1.18

First version of supervisord input plugin with tests included

fc56054

Added new dependency (xmlrpc) to licenses list

4d75a70

Merge remote-tracking branch 'origin/inputs/supervisor' into inputs/s…

f77b75b

…upervisor

Renamed variable to satisfy linter's requirements

adff627

Fixed go.sum content and line separators

8169853

Fixed LICENSE_OF_DEPENDENCIES.md new dependency position

c314cab

niasar and others added 4 commits September 25, 2021 08:53

Merge branch 'influxdata:master' into master

466fc47

Merge branch 'master' into inputs/supervisor

87a6e95

# Conflicts: # docs/LICENSE_OF_DEPENDENCIES.md # go.mod

Fixing some mistakes after resolving conflicts

b47a584

Added entry to LICENSE_OF_DEPENDENCIES.md

e0289ae

powersj suggested changes Sep 30, 2021

View reviewed changes

plugins/inputs/supervisor/README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

docker-compose.yml Outdated Show resolved Hide resolved

plugins/inputs/supervisor/README.md Outdated Show resolved Hide resolved

= added 2 commits October 9, 2021 19:58

Integration tests now using pure debian image. Removed requirement to…

527391f

… disable basic auth. Added details about using plugin with authentication enabled.

Now readme.md is tracked from master

59a69f8

niasar requested a review from powersj October 10, 2021 07:08

srebhan reviewed Jan 6, 2022

View reviewed changes

srebhan self-assigned this Jan 6, 2022

powersj added the waiting for response waiting for response from contributor label Jul 25, 2022

reimda mentioned this pull request Jul 26, 2022

add supervisord program status plugins #5126

Closed

telegraf-tiger bot removed the waiting for response waiting for response from contributor label Jul 26, 2022

pavel.paulikevich added 4 commits August 2, 2022 17:00

Merged latest master and integration tests refactoring with testconta…

ced1ec8

…iners

Making readme-linter happy

39f041c

Making readme-linter happy

b18facb

Merge branch 'master' into inputs/supervisor

b5e3a81

Fixed LICENSE_OF_DEPENDENCIES.md

af09879

pavel.paulikevich and others added 3 commits August 3, 2022 23:09

Merge branch 'master' into inputs/supervisor

e02d50f

Use string for server tag configuration and readme changes

323438e

Rework of server_tag checks and readme changes

ec338ca

niasar requested a review from reimda August 4, 2022 15:57

Always include target related tags

5ae5699

reimda suggested changes Aug 5, 2022

View reviewed changes

niasar added 2 commits August 6, 2022 13:03

Renaming tags

740e7c2

Changing readme to match new plugin output

cf4616f

niasar requested a review from reimda August 6, 2022 12:26

srebhan approved these changes Aug 8, 2022

View reviewed changes

srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 8, 2022

powersj approved these changes Aug 8, 2022

View reviewed changes

reimda approved these changes Aug 8, 2022

View reviewed changes

powersj merged commit b80d34a into influxdata:master Aug 8, 2022

sjwang90 mentioned this pull request Sep 7, 2022

Telegraf 1.24 influxdata/docs-v2#4422

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Supervisord input plugin #9015

feat: Supervisord input plugin #9015

niasar commented Mar 18, 2021 •

edited

Loading

telegraf-tiger bot left a comment

sjwang90 commented Sep 20, 2021

niasar commented Sep 23, 2021

telegraf-tiger bot commented Sep 25, 2021

Artifact URLs

niasar commented Sep 25, 2021

powersj left a comment

telegraf-tiger bot commented Oct 9, 2021

Artifact URLs

lcgogo commented Dec 28, 2021

sjwang90 commented Jan 4, 2022

powersj commented Jan 4, 2022

srebhan left a comment

powersj commented Jul 25, 2022

reimda commented Jul 26, 2022

niasar commented Jul 27, 2022

niasar commented Aug 2, 2022 •

edited

Loading

srebhan commented Aug 2, 2022

srebhan commented Aug 3, 2022

telegraf-tiger bot commented Aug 6, 2022

Artifact URLs

powersj left a comment

feat: Supervisord input plugin #9015

feat: Supervisord input plugin #9015

Conversation

niasar commented Mar 18, 2021 • edited Loading

Required for all PRs:

telegraf-tiger bot left a comment

Choose a reason for hiding this comment

sjwang90 commented Sep 20, 2021

niasar commented Sep 23, 2021

telegraf-tiger bot commented Sep 25, 2021

Artifact URLs

niasar commented Sep 25, 2021

powersj left a comment

Choose a reason for hiding this comment

telegraf-tiger bot commented Oct 9, 2021

Artifact URLs

lcgogo commented Dec 28, 2021

sjwang90 commented Jan 4, 2022

powersj commented Jan 4, 2022

srebhan left a comment

Choose a reason for hiding this comment

powersj commented Jul 25, 2022

reimda commented Jul 26, 2022

niasar commented Jul 27, 2022

niasar commented Aug 2, 2022 • edited Loading

srebhan commented Aug 2, 2022

srebhan commented Aug 3, 2022

telegraf-tiger bot commented Aug 6, 2022

Artifact URLs

powersj left a comment

Choose a reason for hiding this comment

niasar commented Mar 18, 2021 •

edited

Loading

niasar commented Aug 2, 2022 •

edited

Loading