-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to enable gzip compression in elasticsearch output #8913
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤝 ✅ CLA has been signed. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good with one exception. Please do not modify the existing test but rather add a new one that tests gzip-compression! Both setups should be tested!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@tuannh99 there were some linter errors found, would you mind resolving them? Thanks! |
@tuannh99 any news here? |
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
034e442
to
3c33801
Compare
@srebhan I've fixed the linter. Tested changes using golangci-lint locally, it should be expressed in CI result soon. |
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
(cherry picked from commit b56ffdc)
…xdata#8913) (cherry picked from commit b56ffdc)
This adds ability to enable gzip compression in elasticsearch output.
Default is disable.
https://prnt.sc/107gocy
https://prnt.sc/107gpad
https://prnt.sc/107gmfu
https://prnt.sc/107gnox
Required for all PRs: