Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display error message on badly formatted config string array (eg. namepass) #8910

Merged
merged 2 commits into from
Feb 26, 2021
Merged

Display error message on badly formatted config string array (eg. namepass) #8910

merged 2 commits into from
Feb 26, 2021

Conversation

ivorybilled
Copy link
Contributor

resolves #7616

telegraf-tiger[bot]
telegraf-tiger bot approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 ✅ CLA has been signed. Thank you!

@ivorybilled
Copy link
Contributor Author

!retry-checks

srebhan
srebhan approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@srebhan srebhan added area/configuration fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Feb 26, 2021
@srebhan srebhan self-assigned this Feb 26, 2021
helenosheaa
helenosheaa approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@helenosheaa helenosheaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ivorybilled ivorybilled merged commit 956350d into master Feb 26, 2021
@ivorybilled ivorybilled deleted the errorOnBadStringArray branch February 26, 2021 18:58
@powersj powersj mentioned this pull request Aug 8, 2022
Closed
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@ivorybilled
Display error message on badly formatted config string array (eg. nam…
94ccb82 
…epass) (influxdata#8910)

* add error when expected string array is not in string array format

* add word
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssoroka ssoroka ssoroka approved these changes

@srebhan srebhan srebhan approved these changes

@helenosheaa helenosheaa helenosheaa approved these changes

@telegraf-tiger telegraf-tiger[bot] telegraf-tiger[bot] approved these changes

Assignees

@srebhan srebhan

Labels
area/configuration fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Array of string options are silently ignored if set to a string
4 participants
@ivorybilled @ssoroka @srebhan @helenosheaa