Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PPID field to procstat input plugin #8887

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Add PPID field to procstat input plugin #8887

merged 1 commit into from
Mar 3, 2021

Conversation

reimda
Copy link
Contributor

@reimda reimda commented Feb 20, 2021

Closes #8851

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Feb 20, 2021
telegraf-tiger[bot]
telegraf-tiger bot approved these changes Feb 20, 2021
View reviewed changes
Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 ✅ CLA has been signed. Thank you!

@reimda
Copy link
Contributor Author

reimda commented Feb 20, 2021

Here are builds of this PR for testing

srebhan
srebhan reviewed Feb 22, 2021
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but you add a field to an existing metric... ;-P Please tell me if you allow yourself to do this! :-)

@srebhan srebhan self-assigned this Feb 22, 2021
@reimda
Copy link
Contributor Author

reimda commented Mar 3, 2021

The code looks good, but you add a field to an existing metric... ;-P Please tell me if you allow yourself to do this! :-)

@srebhan I think it's ok because it's small and useful. I just added some documentation about changing the metric format that includes my justification for adding fields like this. https://github.com/influxdata/telegraf/wiki/MetricFormatChanges Let me know if it makes sense to you. Thanks!

@reimda reimda merged commit 851136f into master Mar 3, 2021
@reimda reimda deleted the procstat_ppid branch March 3, 2021 04:42
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@reimda
Add PPID field to procstat input plugin (influxdata#8887)
92c63df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan left review comments

@helenosheaa helenosheaa helenosheaa approved these changes

@ivorybilled ivorybilled ivorybilled approved these changes

@telegraf-tiger telegraf-tiger[bot] telegraf-tiger[bot] approved these changes

Assignees

@srebhan srebhan

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PPID to procstat input plugin
4 participants
@reimda @srebhan @helenosheaa @ivorybilled