Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add top stat info to mongodb plugin #8861

Merged
merged 3 commits into from
Mar 16, 2021
Merged

Add top stat info to mongodb plugin #8861

merged 3 commits into from
Mar 16, 2021

Conversation

denispershin
Copy link
Contributor

@denispershin denispershin commented Feb 15, 2021 •
edited
Loading

Required for all PRs:

  • Associated README.md updated.
  • Has appropriate unit tests.

Changes:

Added information (insert, update, queries, remove etc...) about each collection in replica set.
More information in documentation

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Feb 15, 2021
telegraf-tiger[bot]
telegraf-tiger bot requested changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@denispershin
Copy link
Contributor Author

!signed-cla

telegraf-tiger[bot]
telegraf-tiger bot approved these changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 ✅ CLA has been signed. Thank you!

@denispershin denispershin changed the title Add top stat info Add top stat info in mongodb plugin Feb 17, 2021
@denispershin denispershin changed the title Add top stat info in mongodb plugin Add top stat info to mongodb plugin Feb 23, 2021
srebhan
srebhan reviewed Mar 4, 2021
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only very minor comments in the code. Please take a look and let me know once you addressed them.

@srebhan srebhan self-assigned this Mar 4, 2021
@denispershin denispershin requested a review from srebhan March 11, 2021 12:59
srebhan
srebhan approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 11, 2021
srebhan
srebhan approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks missed this one...

helenosheaa
helenosheaa approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@helenosheaa helenosheaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sspaink sspaink merged commit 8a47d6f into influxdata:master Mar 16, 2021
@denispershin denispershin deleted the Add_top_stats branch March 27, 2021 20:13
jblesener pushed a commit to jblesener/telegraf that referenced this pull request Apr 18, 2021
@denispershin @jblesener
Add top stat info to mongodb plugin (influxdata#8861)
fc57a4f 
* Add top stat info

* fixes after review

* fix README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@helenosheaa helenosheaa helenosheaa approved these changes

@telegraf-tiger telegraf-tiger[bot] telegraf-tiger[bot] approved these changes

Assignees

@srebhan srebhan

Labels
area/mongodb feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@denispershin @srebhan @helenosheaa @sspaink