-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Starlark script for outputting Line Protocol shape...for sizing #8852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla
06e4ae2
to
d3219d2
Compare
d3219d2
to
fcef7f9
Compare
@srebhan should be good to go now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the commented code.
Furthermore, you drop the original metric, is this correct?
@srebhan Removed commented code. The intention was to drop the original metric, yes. That's up for debate currently, however :). For now, it's fine. |
@samhld please add at least a comment in the example that the original metric is dropped. Furthermore, your expected values and the actual output of the script diverge. Please check what's going on here and fix one or the other. |
Ugh, they didn't use to. I'll have to investigate why this happened. |
I know why -- will re-commit fix shortly! |
@srebhan Ok gtg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me.
Required for all PRs: