Filter data out from system databases for Azure SQL DB only #8849
Conversation
a92bc7f to
5fd2726
Compare
|
Hmmm as the discussion shows finding a consent on what ppl want is difficult. How about make this exclude list a config option that is, by default, set to the list you want to exclude? People really wanting to monitor that DBs for whatever reason are then free to do so. |
Thank you for the suggestion. In Azure SQL database offering, Azure SQL manages system databases(modelDB, msdb ..) and customer will likely not find any useful information for monitoring in these system databases that are currently filtered out. We think the filtered list of system databases are standard and not useful for monitoring. Even if we make it as an option in config for customers to exclude, most/all customers might always keep the default config as including system databases just dumps more data without actionable results. I agree it gives flexibility, but I think the config option might not be used to include other system databases as the data does not make sense for Azure SQL offering. We wanted to keep it simple by excluding them in the query, but if you think it is a concern, we can follow your suggestion. Let us know what you think. Thanks! |
|
looks like there's conflicts to resolve. Also is it at all possible that this data is useful to some customers, and we should instead parameterize it? |
I don't think there is conflict - the change is only for "single database" offering of Azure , not for SQL Managed instance ( multiple DBs') or on-prem SQL Server ( multiple-DB's). I think you risk over parameterizing things too, there is no one that will get any benefit looking at these couners for master/model/MSDB databases. If you make it a config and then make the default as what backward compat was, then you remove usefulness of it, if we parameterize then would want default for param to be to exclude system Dbs not the other way around. I personally think no need of parameterization |
|
@denzilribeiro I think @ssoroka is referring to the merge conflict in |
@ssoroka I'll work on resolving the merge conflict and push a new iteration. Thanks everyone for the review! |
relevant for monitoring in Azure SQL Please enter the commit message for your changes. Lines starting
|
Fetched the latest from upstream and resolved the conflict. |
|
* Excluding data from system databases like msdb,model which are not relevant for monitoring in Azure SQL Please enter the commit message for your changes. Lines starting * Addressing review comments to handle null scenarios (cherry picked from commit 35b75e9)
…ta#8849) * Excluding data from system databases like msdb,model which are not relevant for monitoring in Azure SQL Please enter the commit message for your changes. Lines starting * Addressing review comments to handle null scenarios
Azure SQL DB has few system databases like msdb, model .... which emits data and are not useful for customers for monitoring. However, we're collecting data from telegraf queries and seems unnecessary as this data does not make sense for single DB customers. Excluding these system databases from performance DMVs to lower the amount of data emitted.
Please enter the commit message for your changes. Lines starting
Required for all PRs: