Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate the response from InfluxDB after writing/creating a database to avoid json parsing panics/errors #8775

Merged
merged 10 commits into from
Feb 10, 2021
Merged

Validate the response from InfluxDB after writing/creating a database to avoid json parsing panics/errors #8775

merged 10 commits into from
Feb 10, 2021

Conversation

ivorybilled
Copy link
Contributor

fixes #8626

telegraf-tiger[bot]
telegraf-tiger bot approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 ✅ CLA has been signed. Thank you!

@helenosheaa helenosheaa added the fix pr to fix corresponding bug label Feb 4, 2021
srebhan
srebhan approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@srebhan srebhan self-assigned this Feb 5, 2021
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 5, 2021
helenosheaa
helenosheaa approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@helenosheaa helenosheaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ivorybilled ivorybilled merged commit c25ae52 into master Feb 10, 2021
@ivorybilled ivorybilled deleted the validateInfluxDbOutputResponse branch February 10, 2021 19:45
ssoroka pushed a commit that referenced this pull request Feb 17, 2021
@ivorybilled @ssoroka
Validate the response from InfluxDB after writing/creating a database…
4db44f2 
… to avoid json parsing panics/errors (#8775)

* Validate the response from InfluxDB after writing/creating a database to avoid json parsing panics.

* Testing windows signing - ignore

* Update config.yml

* adding signing to workflow - test

* Updated config.yml

* Updated config.yml

* Updated config.yml

* Updated config.yml

* revert circleci test changes

* Various updates

(cherry picked from commit c25ae52)
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@ivorybilled
Validate the response from InfluxDB after writing/creating a database…
2d404fb 
… to avoid json parsing panics/errors (influxdata#8775)

* Validate the response from InfluxDB after writing/creating a database to avoid json parsing panics.

* Testing windows signing - ignore

* Update config.yml

* adding signing to workflow - test

* Updated config.yml

* Updated config.yml

* Updated config.yml

* Updated config.yml

* revert circleci test changes

* Various updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssoroka ssoroka ssoroka left review comments

@srebhan srebhan srebhan approved these changes

@helenosheaa helenosheaa helenosheaa approved these changes

@telegraf-tiger telegraf-tiger[bot] telegraf-tiger[bot] approved these changes

Assignees

@srebhan srebhan

Labels
fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

telegraf run a period, report goroutine error
4 participants
@ivorybilled @ssoroka @srebhan @helenosheaa