-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inputs.ping regression: Add back required "hostPinger" function for "exec" method #8764
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤝 ✅ CLA has been signed. Thank you!
Thank you for fixing this! For those who have encountered this issue via an Internet search and want to downgrade Telegraf until a fixed release is available, as of now it is still possible to download the previous Telegraf version from the official downloads portal. For example, on Debian/Ubuntu, instead of fetching |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@digitalcircuit can you confirm that this change fixes the problem?
@sspaink please add a "Fixes #..." to the PR description. This way the issue is also closed when this is merged IIRC. |
@srebhan Pardon the delay, I've only just now had the time to test this. ✔️ After compiling from source and building the appropriate package (had to also install
|
Any ETA on when the PPAs will be updated? |
(cherry picked from commit 03fe914)
Required for all PRs:
fixes #8766
This pull request addresses the issue @NZSmartie found and reported in #8704. There was a regression due to the pr #8679 which removed a required function which led to a instant panic when using the "exec" method for inputs.ping. I added an integration unit test to cover for this case in the future that ensures
init()
is correct.