Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with elasticsearch output being really noisy about some errors #8748

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Fix issue with elasticsearch output being really noisy about some errors #8748

merged 1 commit into from
Jan 27, 2021

Conversation

ssoroka
Copy link
Contributor

@ssoroka ssoroka commented Jan 25, 2021

resolves #7393

telegraf-tiger[bot]
telegraf-tiger bot approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 ✅ CLA has been signed. Thank you!

@srebhan
Copy link
Member

srebhan commented Jan 27, 2021

Hmm now only the first error is shown. If this is what you want, please at least add a comment to the break to prevent the next one to remove it because he/she cannot guess the intention behind it.

However I would prefer to group the errors by err.Error.Reason and output the unique set of reasons or whatever describes the error best. This way you would only get one error per error type but you do see all errors! Additionally we could collect the IDs per error type so we can output the same information as before in less log-lines...

What do you think? I could even do it if you want me to...

@srebhan srebhan self-assigned this Jan 27, 2021
@ssoroka
Copy link
Contributor Author

ssoroka commented Jan 27, 2021

@srebhan going to merge this, but open to improving it in another PR.

@ssoroka ssoroka merged commit 52aaadf into master Jan 27, 2021
@ssoroka ssoroka deleted the elastic branch January 27, 2021 21:01
ssoroka added a commit that referenced this pull request Jan 27, 2021
@ssoroka
Fix issue with elasticsearch output being really noisy about some err…
ec7f1fa 
…ors (#8748)

(cherry picked from commit 52aaadf)
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@ssoroka
Fix issue with elasticsearch output being really noisy about some err…
5cad60d 
…ors (influxdata#8748)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helenosheaa helenosheaa helenosheaa approved these changes

@ivorybilled ivorybilled ivorybilled approved these changes

@telegraf-tiger telegraf-tiger[bot] telegraf-tiger[bot] approved these changes

Assignees

@srebhan srebhan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Telegraf log gets spammed/flooded if Elasticsearch receiver is in read-only state
4 participants
@ssoroka @srebhan @helenosheaa @ivorybilled