Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the ability to configure inputs.exec error truncation #8333

Merged
merged 6 commits into from
Mar 18, 2021
Merged

add the ability to configure inputs.exec error truncation #8333

merged 6 commits into from
Mar 18, 2021

Conversation

ssoroka
Copy link
Contributor

@ssoroka ssoroka commented Oct 28, 2020 •
edited
Loading

No description provided.

@ssoroka ssoroka changed the title add the ability to configure inpputs.exec error truncation add the ability to configure inputs.exec error truncation Oct 28, 2020
@sjwang90 sjwang90 added area/exec feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Nov 24, 2020
@sjwang90 sjwang90 added this to the Planned milestone Dec 14, 2020
srebhan
srebhan reviewed Dec 15, 2020
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have a minor comment (see code). Could you please also add a test-case where you actually truncate with a non-default argument!? Just to make sure... :-)

@srebhan srebhan self-assigned this Dec 15, 2020
@srebhan
Copy link
Member

srebhan commented Jan 6, 2021

@ssoroka ping... ;-P

@srebhan
Copy link
Member

srebhan commented Jan 26, 2021

@ssoroka any news on this?

@sjwang90 sjwang90 removed this from the Planned milestone Jan 29, 2021
@helenosheaa
Copy link
Member

When Dave and I paired on reviews we were wondering what problem this is trying to solve? When would the user know that they need this?

sspaink
sspaink approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@sspaink sspaink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ssoroka
Copy link
Contributor Author

ssoroka commented Mar 16, 2021

exec truncates the output by default, so you might not be able to see the whole message about what is causing the script to fail. There's an open issue or user request for this somewhere; not sure why it's not linked.

An alternative (or corollary) to this is to show the whole output when running in debug, and then adjusting the length is less of an issue.

@ssoroka ssoroka merged commit 4dcc3c0 into master Mar 18, 2021
@ssoroka ssoroka deleted the exec-truncate branch March 18, 2021 21:21
reimda pushed a commit that referenced this pull request Apr 7, 2021
@ssoroka @reimda
exec plugins should not truncate messages in debug mode (#8333)
aff9454 
(cherry picked from commit 4dcc3c0)
jblesener pushed a commit to jblesener/telegraf that referenced this pull request Apr 18, 2021
@ssoroka @jblesener
exec plugins should not truncate messages in debug mode (influxdata#8333
c7a4886 
)
@powersj powersj mentioned this pull request Aug 4, 2022
Closed
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@ssoroka @reimda
exec plugins should not truncate messages in debug mode (influxdata#8333
f1faeb3 
)

(cherry picked from commit 4dcc3c0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan left review comments

@sspaink sspaink sspaink approved these changes

Assignees

@srebhan srebhan

Labels
area/exec feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ssoroka @srebhan @helenosheaa @sspaink @sjwang90