Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka sasl-mechanism auth support #8318

Merged
merged 5 commits into from
Oct 28, 2020
Merged

kafka sasl-mechanism auth support #8318

merged 5 commits into from
Oct 28, 2020

Conversation

ssoroka
Copy link
Contributor

@ssoroka ssoroka commented Oct 26, 2020

No description provided.

@ssoroka
Copy link
Contributor Author

ssoroka commented Oct 26, 2020

waiting for some confirmation that this works

@luisgf
Copy link

luisgf commented Oct 27, 2020

I'm really interested in this feature. any plans to merge?

@ssoroka
Copy link
Contributor Author

ssoroka commented Oct 27, 2020

Absolutely. I'd love it if you could try it out and provide feedback.

You can grab the build at one of these to try it out
[removed] -- see latest post for latest build

@luisgf
Copy link

luisgf commented Oct 27, 2020

Hello @ssoroka

Installed telegraf-1.17.0%7Ef45cc9e1-0.x86_64.rpm.

Here the snippet of kafka output section:

[[outputs.kafka]]
  brokers = ["localhost:9092"]
  topic = "metrics"
  sasl_username = "telegraf"
  sasl_password = "telegraf"
  sasl_mechanism = "SCRAM-SHA-512"
  routing_tag = "host"
  client_id = "Telegraf"

Telegraf doesn't start. Seems that sasl_mechanism is not recognised.

[root@server user]# telegraf --test
2020-10-27T16:40:55Z I! Starting Telegraf 
2020-10-27T16:40:55Z I! Using config file: /etc/telegraf/telegraf.conf
2020-10-27T16:40:55Z E! [telegraf] Error running agent: Error loading config file /etc/telegraf/telegraf.conf: Error parsing kafka array, line 20: field corresponding to `sasl_mechanism' is not defined in kafka.Kafka

@ssoroka
Copy link
Contributor Author

ssoroka commented Oct 27, 2020

k, I'll investigate and respond shortly

@ssoroka
Copy link
Contributor Author

ssoroka commented Oct 27, 2020

so I had only added it for the inputs.kafka_consumer, but I'm adding it now to the outputs.kafka.. but I realize I also missed a bunch of stuff. will add this shortly.

Copy link
Contributor

@reimda reimda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Let's merge as soon as we get a successful test

@ssoroka
Copy link
Contributor Author

ssoroka commented Oct 28, 2020

@luisgf
Here's the updated packages for you to test.
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf-1.17.0%7Eb02f2cc3-0.aarch64.rpm
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf-1.17.0%7Eb02f2cc3-0.armel.rpm
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf-1.17.0%7Eb02f2cc3-0.armv6hl.rpm
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf-1.17.0%7Eb02f2cc3-0.i386.rpm
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf-1.17.0%7Eb02f2cc3-0.s390x.rpm
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf-1.17.0%7Eb02f2cc3-0.x86_64.rpm
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf-1.17.0%7Eb02f2cc3_darwin_amd64.tar.gz
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf-1.17.0%7Eb02f2cc3_freebsd_amd64.tar.gz
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf-1.17.0%7Eb02f2cc3_freebsd_i386.tar.gz
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf-1.17.0%7Eb02f2cc3_linux_amd64.tar.gz
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf-1.17.0%7Eb02f2cc3_linux_arm64.tar.gz
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf-1.17.0%7Eb02f2cc3_linux_armel.tar.gz
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf-1.17.0%7Eb02f2cc3_linux_armhf.tar.gz
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf-1.17.0%7Eb02f2cc3_linux_i386.tar.gz
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf-1.17.0%7Eb02f2cc3_linux_mips.tar.gz
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf-1.17.0%7Eb02f2cc3_linux_mipsel.tar.gz
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf-1.17.0%7Eb02f2cc3_linux_s390x.tar.gz
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf-1.17.0%7Eb02f2cc3_static_linux_amd64.tar.gz
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf-1.17.0%7Eb02f2cc3_windows_amd64.zip
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf-1.17.0%7Eb02f2cc3_windows_i386.zip
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf_1.17.0%7Eb02f2cc3-0_amd64.deb
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf_1.17.0%7Eb02f2cc3-0_arm64.deb
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf_1.17.0%7Eb02f2cc3-0_armel.deb
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf_1.17.0%7Eb02f2cc3-0_armhf.deb
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf_1.17.0%7Eb02f2cc3-0_i386.deb
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf_1.17.0%7Eb02f2cc3-0_mips.deb
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf_1.17.0%7Eb02f2cc3-0_mipsel.deb
https://67924-33258973-gh.circle-artifacts.com/0/build/dist/telegraf_1.17.0%7Eb02f2cc3-0_s390x.deb

@luisgf
Copy link

luisgf commented Oct 28, 2020

Hello @ssoroka works! I'm connected to my kafka brokers using SCRAM-SHA-512 authentication.

@ssoroka ssoroka merged commit e83a165 into master Oct 28, 2020
@ssoroka ssoroka deleted the kafka-sasl-mechanism branch October 28, 2020 16:17
ssoroka added a commit that referenced this pull request Oct 28, 2020
@Neustradamus
Copy link

@ssoroka: Thanks a lot for all about SCRAM.

Linked to:

@douglasawh
Copy link

GSSAPI is still listed as experimental? Why is that the case?

arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants