Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple keys when parsing cgroups #8108

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Allow multiple keys when parsing cgroups #8108

merged 1 commit into from
Jul 8, 2021

Conversation

andrenth
Copy link
Contributor

This PR extends the key/value parser to support multiple space-separated keys followed by a value. This allows the plugin to parse blkio cgroup statistics from files such as blkio.throttle.io_service_bytes and blkio.throttle.io_serviced.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@sjwang90 sjwang90 added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Sep 16, 2020
sspaink
sspaink approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@sspaink sspaink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sspaink sspaink added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 23, 2021
@ssoroka ssoroka merged commit 59e79fa into influxdata:master Jul 8, 2021
reimda pushed a commit that referenced this pull request Jul 28, 2021
@andrenth @reimda
Allow multiple keys when parsing cgroups (#8108)
f4e0d74 
(cherry picked from commit 59e79fa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssoroka ssoroka ssoroka approved these changes

@sspaink sspaink sspaink approved these changes

Assignees
No one assigned
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrenth @ssoroka @sspaink @sjwang90