update godirwalk to v1.16.1 (dragonfly support) #7987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Most importantly, this version runs on Dragonfly BSD, which might be an issue that potential users would care about. 2. Re-issues syscall request after EINTR. More resiliant on Go v1.14 and above, where syscall is more likely to return syscall.EINTR. Also, alongside the place where it would instead call golang.org/x/sys/unix, but it is commented out, I include the equivalent code for checking for unix.EINTR, to make it less likely that I forget to change the EINTR check if I ever convert it to use golang.org/x/sys/unix rather than syscall. 3. Performance improvements for unix and Windows.
ssoroka
approved these changes
Nov 27, 2020
|
Thank you! |
ssoroka
pushed a commit
that referenced
this pull request
Dec 1, 2020
1. Most importantly, this version runs on Dragonfly BSD, which might be an issue that potential users would care about. 2. Re-issues syscall request after EINTR. More resiliant on Go v1.14 and above, where syscall is more likely to return syscall.EINTR. Also, alongside the place where it would instead call golang.org/x/sys/unix, but it is commented out, I include the equivalent code for checking for unix.EINTR, to make it less likely that I forget to change the EINTR check if I ever convert it to use golang.org/x/sys/unix rather than syscall. 3. Performance improvements for unix and Windows. Co-authored-by: Karrick S. McDermott <karrick@karrick.dev> (cherry picked from commit 11b83db)
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
1. Most importantly, this version runs on Dragonfly BSD, which might be an issue that potential users would care about. 2. Re-issues syscall request after EINTR. More resiliant on Go v1.14 and above, where syscall is more likely to return syscall.EINTR. Also, alongside the place where it would instead call golang.org/x/sys/unix, but it is commented out, I include the equivalent code for checking for unix.EINTR, to make it less likely that I forget to change the EINTR check if I ever convert it to use golang.org/x/sys/unix rather than syscall. 3. Performance improvements for unix and Windows. Co-authored-by: Karrick S. McDermott <karrick@karrick.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most importantly, this version runs on Dragonfly BSD, which might
be an issue that potential users would care about.
Re-issues syscall request after EINTR.
More resiliant on Go v1.14 and above, where syscall is more likely
to return syscall.EINTR.
Also, alongside the place where it would instead call
golang.org/x/sys/unix, but it is commented out, I include the
equivalent code for checking for unix.EINTR, to make it less likely
that I forget to change the EINTR check if I ever convert it to use
golang.org/x/sys/unix rather than syscall.
Performance improvements for unix and Windows.
Required for all PRs:
NOTE: While updated godirwalk package now runs on Dragonfly BSD, I did not test whether the remainder of telegraf also runs on Dragonfly BSD, so I did not add Dragonfly BSD to the README.md file.
NOTE 2: Additional unit tests are in the updated godirwalk package.