Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow histograms with no buckets and summary without quantiles #7740

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

danielnelson
Copy link
Contributor

I don't remember why I disallowed this originally, but it doesn't seem to be a requirement to have quantiles for a summary or buckets for a histogram.

closes: #7705

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson danielnelson merged commit f2dded5 into master Jun 30, 2020
@danielnelson danielnelson deleted the prom-summary-histo-empty-buckets branch June 30, 2020 18:30
danielnelson added a commit that referenced this pull request Jun 30, 2020
rhajek pushed a commit to bonitoo-io/telegraf that referenced this pull request Jul 13, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prometheus fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus Input: Metrics Dropped from Outputs When Overlapping Name Exists
2 participants