sensors: Handle error sentences from sensors #7718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amdgpu drivers produces an output that cannot be handled by sensors:
root@qt5222:~# sensors -A -u
amdgpu-pci-0300
vddgfx:
ERROR: Can't get value of subfeature in0_input: Can't read
vddnb:
ERROR: Can't get value of subfeature in1_input: Can't read
edge:
temp1_input: 40.000
temp1_crit: 80.000
temp1_crit_hyst: 0.000
00000400100-mdio-4
temp1:
temp1_input: 59.000
temp1_crit: 100.000
temp1_max_alarm: 0.000
This results in an invalid parsing of its ouput. Eg:
> sensors,chip=ERROR:\ Can't\ get\ value\ of\ subfeature\ in0_input:\ Can't\ read,feature=isl_curr_soc,host=qt5222,serial=${SERIAL_NUMBER} curr_input=1.6 1592920794000000000
The invalid parsing is due to the different buffer size of stdout and
stderr. Which results on stderr output out of sync with stdout.
Since we do not need the output of stderr, simply ignore it.
Signed-off-by: Ricardo Ribalda <ricardo@ribalda.com>
danielnelson
pushed a commit
that referenced
this pull request
Jun 23, 2020
(cherry picked from commit e8461fe)
rhajek
pushed a commit
to bonitoo-io/telegraf
that referenced
this pull request
Jul 13, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amdgpu drivers produces an output that cannot be handled by sensors:
root@qt5222:~# sensors -A -u
amdgpu-pci-0300
vddgfx:
ERROR: Can't get value of subfeature in0_input: Can't read
vddnb:
ERROR: Can't get value of subfeature in1_input: Can't read
edge:
temp1_input: 40.000
temp1_crit: 80.000
temp1_crit_hyst: 0.000
00000400100-mdio-4
temp1:
temp1_input: 59.000
temp1_crit: 100.000
temp1_max_alarm: 0.000
This results in an invalid parsing of its ouput. Eg:
The invalid parsing is due to the different buffer size of stdout and
stderr. Which results on stderr output out of sync with stdout.
Since we do not need the output of stderr, simply ignore it.
Signed-off-by: Ricardo Ribalda ricardo@ribalda.com
Required for all PRs: