Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve mntr regex to match user specific keys. #7533

Merged
merged 2 commits into from
Jan 27, 2021

Conversation

powerLambda
Copy link
Contributor

@powerLambda powerLambda commented May 18, 2020

Required for all PRs:

Found zookeeper input plugin error as below:

[inputs.zookeeper] Error in plugin: unexpected line in mntr response: "zk_avg_pull-daily-attendence-data-testByQA_read_per_namespace\t137.1803"

This PR is to improve mntr regex to match user specific keys.

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@powerLambda
Copy link
Contributor Author

Bug link #7550

@danielnelson danielnelson added the fix pr to fix corresponding bug label May 21, 2020
@srebhan srebhan self-assigned this Nov 14, 2020
@srebhan
Copy link
Member

srebhan commented Nov 26, 2020

@powerLambda can you please check the comment so we can go forward with this PR!?

@sjwang90 sjwang90 added the wip label Nov 30, 2020
@srebhan
Copy link
Member

srebhan commented Dec 11, 2020

@powerLambda ping!

@sjwang90
Copy link
Contributor

@powerLambda - can you please let us know if you can make the changes to @srebhan's comment. Otherwise we can look for someone on the influx side to finish it up.

Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@powerLambda
Copy link
Contributor Author

@sjwang90 sorry for the late reply, crazy busy for a while.

@sjwang90 sjwang90 removed the wip label Jan 22, 2021
@sjwang90 sjwang90 requested a review from srebhan January 22, 2021 01:03
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 22, 2021
@ssoroka ssoroka merged commit 5c4c0e1 into influxdata:master Jan 27, 2021
ssoroka pushed a commit that referenced this pull request Jan 27, 2021
* improve mntr regex to match user specific keys.

* Update plugins/inputs/zookeeper/zookeeper.go

Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>

Co-authored-by: guoxu <guoxu@chinatelecom.cn>
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
(cherry picked from commit 5c4c0e1)
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
* improve mntr regex to match user specific keys.

* Update plugins/inputs/zookeeper/zookeeper.go

Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>

Co-authored-by: guoxu <guoxu@chinatelecom.cn>
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants