Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mongodb: add additional metrics #7321

Merged
merged 1 commit into from
May 12, 2020
Merged

Mongodb: add additional metrics #7321

merged 1 commit into from
May 12, 2020

Conversation

kostiantyn-nemchenko
Copy link
Contributor

This PR adds more metrics to collect about the following MongoDB parts:

  • assertions
  • database operations
  • documents/index keys usage
  • replication
  • tcmalloc memory management
  • storage
  • version

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@ssoroka ssoroka self-requested a review April 13, 2020 15:36
ssoroka
ssoroka approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@ssoroka ssoroka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think a couple simple strut fields could maybe avoid being pointers, since the presence vs default values seems to make no difference here, but that's maybe just preference as this plugin already uses struct field pointers liberally.
👍 from me.

@kostiantyn-nemchenko
Copy link
Contributor Author

@ssoroka thank you for the review! Any chance to get it merged?

@danielnelson danielnelson added area/mongodb feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels May 12, 2020
@danielnelson danielnelson added this to the 1.15.0 milestone May 12, 2020
@danielnelson danielnelson merged commit 00ad5ba into influxdata:master May 12, 2020
rhajek pushed a commit to bonitoo-io/telegraf that referenced this pull request Jul 13, 2020
@kostiantyn-nemchenko @rhajek
Add additional fields to mongodb input (influxdata#7321)
43f9774 
New metrics include:
- assertions
- database operations
- documents/index keys usage
- replication
- tcmalloc memory management
- storage
- version
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
@kostiantyn-nemchenko
Add additional fields to mongodb input (influxdata#7321)
7fb8101 
New metrics include:
- assertions
- database operations
- documents/index keys usage
- replication
- tcmalloc memory management
- storage
- version
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@kostiantyn-nemchenko
Add additional fields to mongodb input (influxdata#7321)
c2093d9 
New metrics include:
- assertions
- database operations
- documents/index keys usage
- replication
- tcmalloc memory management
- storage
- version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssoroka ssoroka ssoroka approved these changes

Assignees
No one assigned
Labels
area/mongodb feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kostiantyn-nemchenko @ssoroka @danielnelson