Support for SNMP over TCP #5870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glinton
reviewed
May 17, 2019
| @@ -488,6 +488,14 @@ | |||
| revision = "636bf0302bc95575d69441b25a2603156ffdddf1" | |||
| version = "v1.1.1" | |||
|
|
|||
| [[projects]] | |||
| digest = "1:530233672f656641b365f8efb38ed9fba80e420baff2ce87633813ab3755ed6d" | |||
| name = "github.com/golang/mock" | |||
There was a problem hiding this comment.
I see this is a new dependency of gosnmp, maybe if it were generated into the gosnmp_test package we wouldn't need this testing dep? I'd like to have someone look into if this is possible before updating gosnmp.
There was a problem hiding this comment.
I understand that you do not want to include this testing dep, but I am not sure how to fix this.
The new version of gosnmp does have support for SNMP over TCP.
Agents prefixed with 'tcp://' do now get their transport protocol set to TCP. gosnmp handles all the details.
Add a new test to verify that agents prefixed with tcp: use the correct transport protocol. As getConnection does the full connection setup, we need a server listening on the port to allow the test to pass. This server is therefore also set up in the test. Also verify that the other agents still use UDP.
|
Sorry about stranding this PR for so long, while I'd still love the gomock dependency removed it's not enough to hold up this PR. |
danielnelson
approved these changes
Nov 7, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While SNMP is usually done over UDP, it is possible to transport it using TCP. This is specified in RFC 3430 and should be used when transferring lots of data.
This PR adds support for SNMP over TCP to telegraf. The heavy lifting is done by the gosnmp library. Therefore it was only necessary to set the transport protocol for the agents, that should be gathered via TCP. To use it, you have to configure an agent like this:
The notation of prefixing withtcp:has been taken from net-snmp which uses it for their command line tools like snmpbulkwalk.Required for all PRs: