Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Statsd datadog #5791
Statsd datadog #5791
Changes from 6 commits
ff39ba6
ac21921
28cfc58
7d46c82
54c6ecd
dc4fe8a
6b0bc6c
0eff26b
b8d9a30
4dbf947
4903f31
a5757cb
fa4b6e7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielnelson so, the original source code would optimistically continue parsing and warn about bad values within the even message.
Does this fit telegraf? Should these warnings be errors or are logs ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if the message is malformed an error should be returned up from here and then logged. Doing a best effort parse doesn't make sense unless we find that the datadog agent regularly emits bad messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Telegraf generally tries to ignore errors and keep working where it can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done empty string tags before in the zipkin plugin, however, it makes it pretty difficult to query for at least with influxdb.
@danielnelson how are label type tags typically done in telegraf?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the value of having an empty tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know but Datadog events tests in their agent specifically makes allowances for them. We wouldn't have spec compatibility if we didn't allow them. Should we handle them some other way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is allowed to have an empty tag value in InfluxDB, we just toss them at serialize time.