-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postgres plugin: option to remove password in tag #486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @donaldguy, please try to rebase this change off of the 0.3.0 branch and have the PR merge to that branch as well, thank you! If you would like to break backwards-compatability on the 0.3.0 branch, it's no problem, just make a note of it in CHANGELOG.md thanks again! |
Closing in favor of #490 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds option to avoid server tag including password. Disabled by default
for backwards compatibility
This version uses pq.ParseURL to canonicalize to key-value format
before doing sanitazation. So inputs in URL format that enable this option will
switch formats. It easy enough to make a version that removes password while
preserving URL format by adding branching logic with net/url.
It is unclear to me which is preferable. Canonicalization might be seen as a virtue. Also, its tempting to take it one step forward and make host, user, etc. seperate tags rather than a concatted string.
I am open to any suggestions as to the name of the config_key, etc.
Thanks 😄