Improve error from line protocol parser #4786
Conversation
|
On this one we should implement the line counting in machine.go.rl. I think we need to add two ints to the Machine, one for line and one for start of line, these get updated as the machine runs. |
|
Wouldn't that slow down the whole parsing (counting everything all the time) vs just slowing the printing of an error due to counting at error print time? |
|
It can be done with very little overhead at parse time, I think it shouldn't be a noticeable difference, but we should still keep an eye on any change when working on it. |
|
What will happen if you can't open the metrices file? For example, if you are using scripts to generate metrices, and they are creating massive amount of them. The error message will be "found error in line 5000" and you can't look for line 5000... |
|
See #5484 |
Resolves #4743