Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wavefront.go #3711

Merged
merged 3 commits into from
Jan 25, 2018
Merged

Update wavefront.go #3711

merged 3 commits into from
Jan 25, 2018

Conversation

puckpuck
Copy link
Contributor

Required for all PRs:

This fixes a potential issue where the output plugin could in some instances take more than 5 seconds causing all other input plugins to block.

See #3710 and #2919

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson danielnelson added this to the 1.5.2 milestone Jan 25, 2018
@danielnelson danielnelson merged commit 3e4c918 into influxdata:master Jan 25, 2018
danielnelson pushed a commit that referenced this pull request Jan 25, 2018
@danielnelson
Copy link
Contributor

@puckpuck It would be even more robust if this output used a timeout capable replacement for Dial and ip resolution. You might just want to merge the two functions into net.DialTimeout, you should be able to report any loopup error from that function.

@puckpuck
Copy link
Contributor Author

@danielnelson We have plans to do significant enhancements to how the the output plugin communications with the Wavefront proxy service. We are adding HTTP in addition to the existing telnet/socket communication channel. This would be planned in the near future, but we aren't quite ready yet. When that happens I will also add more robustness around the entire communication channel including creation/testing of the network address. Do you have a date already planned for the next Telegraf version post 1.6?

@danielnelson
Copy link
Contributor

1.7 will likely be in April

@puckpuck puckpuck deleted the wavefront-output branch February 2, 2018 15:14
codesmith14 pushed a commit to signalfx/telegraf that referenced this pull request Jun 19, 2018
maxunt pushed a commit that referenced this pull request Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants