Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when tag includes ":", split won't behave as expected. #3514

Closed
wants to merge 1 commit into from

Conversation

sagydr
Copy link

@sagydr sagydr commented Nov 28, 2017

so "bits" would simply be the last split section, and bucketName is join of all-but-the-last sections

Required for all PRs:

  • [V] Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

so "bits" would simply be the last split section, and bucketName is join of all-but-the-last sections
@sagydr
Copy link
Author

sagydr commented Nov 28, 2017

it's my first open-source contribution,
please contact me if i messed up something: sagysrael@gmail.com
thanks.

@danielnelson
Copy link
Contributor

I think this would break the "multi-bit" lines added in #354.

Looking closer into the statsd spec and implementations, I don't think there is any way to encode a colon before the value|type. I'm still open to allowing it, but I think it will not be trivial and we need to ensure we don't slow the parser down if we do it.

@danielnelson
Copy link
Contributor

@sagydr I think it is probably best not to support this functionality due to the way the statsd spec and protocol is created, so I'm going to close this pull request. Hope this does not discourage you from other contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants