Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inputs.infiniband_hw): add a new input plugin for Infiniband card/ports HW statistics #16335

Closed
wants to merge 22 commits into from
Closed

feat(inputs.infiniband_hw): add a new input plugin for Infiniband card/ports HW statistics #16335

wants to merge 22 commits into from

Conversation

izekr
Copy link

@izekr izekr commented Dec 19, 2024

Summary

This PR introduces a new input plugin for Telegraf to collect InfiniBand hardware (RDMA diagnostics) statistics in a Linux environment. The plugin gathers statistics from the hardware counters located in /sys/class/infiniband//ports//hw_counters/

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16334

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Dec 19, 2024
izekri and others added 22 commits December 19, 2024 22:17
@izekri
feat(inputs.infiniband_hw): add a new input plugin for Infiniband car…
7d382de 
…d/ports HW statistics
@srebhan @DStrand1 @izekri
chore(inputs.kinesis_consumer): Cleanup code (influxdata#16267)
7616270 
Co-authored-by: Dane Strandboge <136023093+DStrand1@users.noreply.github.com>
@LandonTClipp @izekri
docs(specs): Add probe as value to startup_error_behavior (influx…
a3f304f 
…data#16052)
@zak-pawel @izekri
test(linters): Enable testifylint: contains, encoded-compare an…
5c9405d 
…d `regexp` (influxdata#16262)
@srebhan @izekri
feat(inputs.systemd_units): Add active_enter_timestamp_us field (infl…
5dec5d6 
…uxdata#16287)
@srebhan @izekri
fix(agent): Skip initialization of second processor state if requested (
88d1684 
influxdata#16290)
@dependabot @izekri
chore(deps): Bump golang.org/x/crypto from 0.29.0 to 0.31.0 (influxda…
b68ecf1 
…ta#16297)
@srebhan @izekri
chore(agent): Add warning about changing default for 'skip_processors…
2d31669 
…_after_aggregators' (influxdata#16302)
@srebhan @izekri
chore(processors.unpivot): Cleanup code and improve performance (infl…
9637780 
…uxdata#16299)
@zak-pawel @izekri
chore: Fix linter findings for revive:unused-receiver in `plugins/i…
c3081ee 
…nputs/[a-e]` (influxdata#16263)
@zomfg @izekri
feat(inputs.docker): Support swarm jobs (influxdata#16292)
7a1f04a
@zak-pawel @izekri
chore: Fix linter findings for revive:unused-receiver in `plugins/i…
efbdb58 
…nputs/[f-k]` (influxdata#16308)
@dependabot @izekri
chore(deps): Bump super-linter/super-linter from 7.2.0 to 7.2.1 (infl…
bddb913 
…uxdata#16313)
@dashpole @izekri
docs(parsers.openmetrics): Update link to specification (influxdata#1…
b89328e 
…6312)

Signed-off-by: David Ashpole <dashpole@google.com>
@dependabot @izekri
chore(deps): Bump github.com/fatih/color from 1.17.0 to 1.18.0 (influ…
e6c99cb 
…xdata#16317)
@dependabot @izekri
chore(deps): Bump github.com/IBM/nzgo/v12 from 12.0.9-0.2023111504325…
b4e06e6 
…9-49c27f2dfe48 to 12.0.9 (influxdata#16319)
@dependabot @izekri
chore(deps): Bump github.com/prometheus/common from 0.60.0 to 0.61.0 (i…
d6f7c06 
…nfluxdata#16318)
@dkhamitov @izekri
fix(inputs.mongodb): Do not dereference nil pointer if gathering data…
2b6def5 
…base stats fails (influxdata#16310)
@zak-pawel @izekri
chore: Fix linter findings for revive:exported in `plugins/inputs/p…
e1880f0 
…*` (influxdata#16307)
@dependabot @izekri
chore(deps): Bump github.com/Azure/go-autorest/autorest/adal from 0.9…
42d34c6 
….23 to 0.9.24 (influxdata#16315)
@srebhan @izekri
chore(deps): Bump github.com/vapourismo/knx-go from v0.0.0-2024021717…
47476e0 
…5130-922a0d50c241 to v0.0.0-20240915133544-a6ab43471c11 (influxdata#16324)
@zak-pawel @izekri
chore: Fix linter findings for revive:unused-receiver in `plugins/i…
b5e5b52 
…nputs/[l-r]` (influxdata#16325)
@srebhan
Copy link
Member

srebhan commented Dec 19, 2024

@izekr is there any reason not to fold this into the infiniband input plugin? You could guard the collection there with a flag or simply produce the new metrics...

@srebhan srebhan self-assigned this Dec 19, 2024
@izekr izekr closed this Dec 19, 2024
@srebhan srebhan mentioned this pull request Dec 20, 2024
Open
1 task
@izekr izekr mentioned this pull request Jan 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@srebhan srebhan

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for RDMA counters for Infinibnad input plugin
8 participants
@izekr @srebhan @izekri @LandonTClipp @zak-pawel @zomfg @dashpole @dkhamitov