Fix postgres extensible text #1601

phemmer · 2016-08-08T06:43:49Z

Required for all PRs:

CHANGELOG.md updated
Sign CLA (if not already signed)

I also did some code cleanup on the nearby code so that it better follows golang coding standards (type switching & less nesting).

phemmer · 2016-08-08T06:45:17Z

plugins/inputs/postgresql_extensible/postgresql_extensible.go

+			case []byte:
+				tags[col] = string(v)
+			case int64:
+				tags[col] = fmt.Sprintf("%d", v)
 			}


I have no idea why the code only supported []byte and int64 tags (though I suspect this is another bug), so I left it as is.

phemmer · 2016-08-08T12:26:13Z

Build failure appears unrelated to the changes in this PR as this PR does not touch the failing plugin, or any code the plugin uses:

2016/08/08 06:49:38 subject: telegraf, error: unable to parse 'cpu_load_short,host=server01 1422568543702900257': invalid field format
--- FAIL: TestRunParserAndGather (0.03s)
    Error Trace:    accumulator.go:188
            nats_consumer_test.go:83
    Error:      unknown measurement cpu_load_short


FAIL
FAIL    github.com/influxdata/telegraf/plugins/inputs/nats_consumer 0.154s

sparrc · 2016-08-09T07:25:49Z

thanks @phemmer

* convert postgresql_extensible byte slice values to strings * code cleanup in postgresql_extensible

phemmer added 2 commits August 8, 2016 02:41

convert postgresql_extensible byte slice values to strings

00c4858

code cleanup in postgresql_extensible

69f2ee3

phemmer reviewed Aug 8, 2016
View reviewed changes

sparrc merged commit 53e31cf into influxdata:master Aug 9, 2016

aurrelhebert pushed a commit to aurrelhebert/telegraf that referenced this pull request Aug 9, 2016

Fix postgres extensible text (influxdata#1601)

6987bbf

* convert postgresql_extensible byte slice values to strings * code cleanup in postgresql_extensible

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix postgres extensible text #1601

Fix postgres extensible text #1601

phemmer commented Aug 8, 2016

phemmer Aug 8, 2016

phemmer commented Aug 8, 2016

sparrc commented Aug 9, 2016

Fix postgres extensible text #1601

Fix postgres extensible text #1601

Conversation

phemmer commented Aug 8, 2016

Required for all PRs:

phemmer Aug 8, 2016

Choose a reason for hiding this comment

phemmer commented Aug 8, 2016

sparrc commented Aug 9, 2016