-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.sysstat): Prevent default sadc_interval from increasing on reload #15212
fix(inputs.sysstat): Prevent default sadc_interval from increasing on reload #15212
Conversation
fddb887
to
588dfaf
Compare
I thought about adding a test for this - |
588dfaf
to
7d70635
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
Summary
On reload, telegraf throws away the
sysstat.Sysstat
instance it has and creates a new one; however, this plugin also relies on package-global state (thefirstTimestamp
variable), which leads to sysstat running sadc with increasingly long intervals following a reload, if the interval to use is not explicitly set viasadc_interval
. Fix this by moving thefirstTimestamp
state into the plugin struct.Checklist
Related issues
resolves #15102