-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parser.prometheusremotewrite): Parse and generate histogram buckets #14952
Conversation
@powersj is your "Do not merge" tag in the description still valid? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I would only directly initialize the fields
...
It wasn't, but the user came back with a comment, so now I need to go look into something. I'll remove the waiting for final review tag. |
note there are some println still in here for debug purposes.
ok updated histograms, rebased on master. Ready for review. |
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @powersj!
Summary
Enable the parsing of histograms that we are currently entirely ignoring in prometheus remote write plugin.
Checklist
Related issues
resolves #14890