Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.kafka_consumer): Mark messages that failed parsing #14585

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

jkerfs
Copy link
Contributor

@jkerfs jkerfs commented Jan 16, 2024

Summary

Mark kafka messages if they failed parsing so that consumer group's partition offsets are committed properly for messages that do not parse properly.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #14579

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jan 16, 2024
@jkerfs
Copy link
Contributor Author

jkerfs commented Jan 16, 2024

!signed-cla

@powersj powersj changed the title feat(inputs.kafka_consumer): mark messages that failed parsing fix(inputs.kafka_consumer): mark messages that failed parsing Jan 16, 2024
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 16, 2024
@telegraf-tiger
Copy link
Contributor

@srebhan srebhan changed the title fix(inputs.kafka_consumer): mark messages that failed parsing fix(inputs.kafka_consumer): Mark messages that failed parsing Jan 17, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkerfs the code looks good, just one small question from my side...

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @jkerfs!

@srebhan srebhan merged commit b72be8e into influxdata:master Jan 17, 2024
28 checks passed
@github-actions github-actions bot added this to the v1.30.0 milestone Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kafka feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kafka_consumer should call markmessage on messages that failed parsing
3 participants