Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.win_perf_counters): Check errors post-collection for skip #14526

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Jan 4, 2024

Summary

This adds the use of check error to an additional error call. This way users who want to opt of additional errors can in fact do so.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #14486

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jan 4, 2024
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jan 5, 2024

@powersj powersj self-assigned this Jan 5, 2024
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 11, 2024
@powersj powersj marked this pull request as ready for review January 11, 2024 21:27
powersj added a commit to powersj/telegraf that referenced this pull request Jan 12, 2024
@powersj powersj removed their assignment Jan 12, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @powersj!

@srebhan srebhan merged commit 9035355 into influxdata:master Jan 15, 2024
4 checks passed
@github-actions github-actions bot added this to the v1.29.3 milestone Jan 15, 2024
powersj added a commit that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skip PDH_CSTATUS_NO_INSTANCE error when using raw values
2 participants