fix(inputs.vsphere): Resolve occasional serverFault #14463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves influxdata#12500 the serverFaultCode "A specified parameter was not correct: querySpec.startTime, querySpec.endTime" results from requests for metrics from the future. Those requests get planned (check: hiwater mark, hwMark) for a plugin-run (-> plugin "interval") in the future in relation to the estimated time the vcenter will have collected the next metrics. This estimated time/interval gets mangled up on a connection error (e.g. connection reset), because the est. interval gets reset to 1. Solution: If we realize (ourselves) that the metric we are about to request is from the future, then... don't request it. Skip it.
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Hipska
approved these changes
Dec 18, 2023
powersj
pushed a commit
that referenced
this pull request
Jan 8, 2024
(cherry picked from commit 19347bf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the serverFaultCode "A specified parameter was not correct: querySpec.startTime, querySpec.endTime" results from requests for metrics from the future.
Those requests get planned (check: hiwater mark, hwMark) for a plugin-run (-> plugin "interval") in the future in relation to the estimated time the vcenter will have collected the next metrics.
This estimated time/interval gets mangled up on a connection error (e.g. connection reset), because the est. interval gets reset to 1.
Solution: If we realize (ourselves) that the metric we are about to request is from the future, then... don't request it. Skip it.
resolves #12500