Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(migrations): Add migration for fieldpass/fielddrop #14401

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Dec 7, 2023

Summary

PR #14012 deprecated fieldpass and fielddrop and replaced those options with the better-named fieldinclude and fieldexclude respectively. Additionally, the deprecated pass and drop options exist.

This PR adds a migration to consolidate all those settings into the new fieldpass and fielddrop.

Checklist

  • No AI generated code was used in this PR

Related issues

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Dec 7, 2023
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Dec 7, 2023

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@powersj powersj merged commit 2a81343 into influxdata:master Dec 7, 2023
@github-actions github-actions bot added this to the v1.29.0 milestone Dec 7, 2023
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 7, 2023
@@ -0,0 +1,3 @@
[[inputs.dummy]]
servers = ["tcp://127.0.0.1:1883"]
fieldexclude = ["valueA", "valueB", "valueC"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that it really matters but current telegraf config parser would process them as ["valueB", "valueC", "valueA"].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/configuration feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants