fix(inputs.ipset): Parse lines with timeout

[powersj]

Parsing raw CLI output, and lines with a timeout shift the values over by two. This checks for timeout, and if it exists adds it as a field as well.

fixes: #14259

[attie]

This looks good, but is still potentially quite fragile if things change / other situations arise in the future. (I've not tested it yet)

I'd suggest iterating over the elements in data, for example (with a pinch of salt, I'm not proficient in Go):

for i, txt := range data {
  if txt == "timeout" {
    val, err := strconv.ParseUint(data[i+1], 10, 64)
    if err != nil {
      acc.AddError(err)
    }
    fields["timeout"] = val

  } else if txt == "packets" {
    val, err := strconv.ParseUint(data[i+1], 10, 64)
    if err != nil {
      acc.AddError(err)
    }
    fields["packets_total"] = val

  } else if txt == "bytes" {
    val, err := strconv.ParseUint(data[i+1], 10, 64)
    if err != nil {
      acc.AddError(err)
    }
    fields["bytes_total"] = val

  }
}

... skipping the first few (3x) fields would probably be okay, and skipping consumed values would help too. It's certainly more processing, but I would hope it's not considered excessive given the improved robustness.

Thoughts?

[powersj]

is still potentially quite fragile if things change / other situations arise in the future

I completely agree, which is why I made my comment in the bug about the unfortunate situation of parsing CLI output.

would probably be okay

Agreed again. I am hesitant to change any logic when the plugin is as old as it is and we have surprisingly not received any issues prior to this but can make the change.

[telegraf-tiger]

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	darwin_arm64.tar.gz	windows_arm64.zip
armel.deb	armv6hl.rpm	freebsd_amd64.tar.gz	windows_i386.zip
armhf.deb	i386.rpm	freebsd_armv7.tar.gz
i386.deb	ppc64le.rpm	freebsd_i386.tar.gz
mips.deb	riscv64.rpm	linux_amd64.tar.gz
mipsel.deb	s390x.rpm	linux_arm64.tar.gz
ppc64el.deb	x86_64.rpm	linux_armel.tar.gz
riscv64.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_riscv64.tar.gz
		linux_s390x.tar.gz

[attie]

Looks good to me, thank you!

I hope to test this out tomorrow, and I'll give my thumbs up when confirmed... though I trust your testing.

[srebhan]

Looks good to me. Thanks @powersj!

[attie]

"tomorrow" ... works great, many thanks!