feat(socket_listener): Add vsock support to socket listener and writer #14172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add vsock case to Connect() - Sanity check for CID and port parameter
srebhan
reviewed
Oct 24, 2023
|
|
||
| addrTuple := strings.SplitN(u.String(), ":", 2) | ||
|
|
||
| //check if address string has two tokens |
There was a problem hiding this comment.
Please leave a space between // and the comment as otherwise this might be interpreted as a comment targetted for a machine/go directive...
Suggested change
| //check if address string has two tokens | |
| // Check address string for containing two tokens |
Comment on lines
98
to
100
| //parse CID and port number from address string | ||
| // CID and port numner are 32 bit | ||
| // source: https://man7.org/linux/man-pages/man7/vsock.7.html |
There was a problem hiding this comment.
Same as above
Suggested change
| //parse CID and port number from address string | |
| // CID and port numner are 32 bit | |
| // source: https://man7.org/linux/man-pages/man7/vsock.7.html | |
| // Parse CID and port number from address string both being 32-bit | |
| // source: https://man7.org/linux/man-pages/man7/vsock.7.html |
| if spl[0] == "vsock" { | ||
| addrTuple := strings.SplitN(spl[1], ":", 2) | ||
|
|
||
| //check if address string has two tokens |
There was a problem hiding this comment.
See comment on input
Suggested change
| //check if address string has two tokens | |
| // Check address string for containing two tokens |
Comment on lines
70
to
72
| //parse CID and port number from address string | ||
| // CID and port numner are 32 bit | ||
| // source: https://man7.org/linux/man-pages/man7/vsock.7.html |
There was a problem hiding this comment.
See comment on input
Suggested change
| //parse CID and port number from address string | |
| // CID and port numner are 32 bit | |
| // source: https://man7.org/linux/man-pages/man7/vsock.7.html | |
| // Parse CID and port number from address string both being 32-bit | |
| // source: https://man7.org/linux/man-pages/man7/vsock.7.html |
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6382
Added virtual socket (vsock) support to the inputs.socket_listener and outputs.socket_writer plugins
So far I could find out, it is not possible to create a vsock listener on the host and write to the same virtual socket from the host, you have to connect from a virtual machine, therefore I have not included additional unit tests