-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.mqtt): Reference correct password variable #14041
Conversation
Thanks so much for the pull request! |
!signed-cla |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Telegraf 1.25.3 works for me with mqtt output, mqtt v5 and EMQX as an MQTT Server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This in fact does look like a regression, but from a commit last week, long after v1.26.0.
TIL that there is a Password
variable in the config module lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
O M G! Thanks for catching this @nexeck!
(cherry picked from commit aa2990d)
For me, connecting to MQTT with username/password and mqttv5 stopped working.
Not sure, but shouldn't it be cfg.Password instead of the config.Password Type?