Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.sql): Add oracle driver #13978

Merged
merged 14 commits into from
Oct 5, 2023

Conversation

michelle-costa
Copy link
Contributor

Required for all PRs

Added the Oracle drive to the SQL plugin to monitor this type of database

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added area/sql feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Sep 22, 2023
@srebhan
Copy link
Member

srebhan commented Sep 25, 2023

Thanks for the PR @michelle-costa! Please sign the CLA so we can review this PR! Furthermore, it would be good to fix the CI tests before review...

@srebhan srebhan self-assigned this Sep 25, 2023
@powersj
Copy link
Contributor

powersj commented Sep 25, 2023

!signed-cla

Looks like you did sign the CLA, but instead of your username you put a link to your profile.

@powersj
Copy link
Contributor

powersj commented Sep 25, 2023

!signed-cla

@powersj
Copy link
Contributor

powersj commented Sep 25, 2023

@michelle-costa if you could get the remaining tests to pass that would be the test next.

Looks like the current failure is a not clean go.mod, so please run:

go mod tidy

and check in any changes.

Thanks!

@powersj powersj added the waiting for response waiting for response from contributor label Sep 25, 2023
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the Oracle driver @michelle-costa! I do have two small comments and a request: Can you please also document the new driver in docs/SQL_DRIVERS_INPUT.md!? Furthermore, please run make tidy before checking in the code to keep our CI happy...

@srebhan srebhan changed the title feat(inputs.sql): add the oracle drive into the SQL plugin feat(inputs.sql): Add oracle driver Sep 26, 2023
@srebhan
Copy link
Member

srebhan commented Oct 2, 2023

@michelle-costa please run make tidy and check-in the changes and we are good to go...

@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Oct 2, 2023
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 2, 2023

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 3.23 % for linux amd64 (new size: 208.7 MB, nightly size 202.1 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@michelle-costa michelle-costa requested a review from srebhan October 3, 2023 13:50
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 4, 2023
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution @michelle-costa!

@srebhan srebhan merged commit f4c56e1 into influxdata:master Oct 5, 2023
@github-actions github-actions bot added this to the v1.29.0 milestone Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sql feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants