-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.sql): Add oracle driver #13978
Conversation
Thanks so much for the pull request! |
Thanks for the PR @michelle-costa! Please sign the CLA so we can review this PR! Furthermore, it would be good to fix the CI tests before review... |
!signed-cla Looks like you did sign the CLA, but instead of your username you put a link to your profile. |
!signed-cla |
@michelle-costa if you could get the remaining tests to pass that would be the test next. Looks like the current failure is a not clean go.mod, so please run:
and check in any changes. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the Oracle driver @michelle-costa! I do have two small comments and a request: Can you please also document the new driver in docs/SQL_DRIVERS_INPUT.md!? Furthermore, please run make tidy
before checking in the code to keep our CI happy...
@michelle-costa please run |
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for you contribution @michelle-costa!
Required for all PRs
Added the Oracle drive to the SQL plugin to monitor this type of database