Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(outputs.stackdriver): Drop metrics on InvalidArgument gRPC error #13931

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Sep 15, 2023

Rather than rely on specific error messages that have in fact changed over time, let's instead drop metrics whenever we get an InvalidArgument gRPC error. These are not retry-able errors and should instead be dropped.

fixes: #13826

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Sep 15, 2023
@powersj powersj changed the title fix(outputs.stackdriver): Update error messages to drop metrics fix(outputs.stackdriver): Drop metrics on InvalidArgument gRPC error Sep 20, 2023
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 20, 2023
@powersj powersj marked this pull request as ready for review September 20, 2023 13:07
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @powersj! One question about testing, can we somehow mock an "invalid argument" response by mimicking the GRPC server? I'm fine with merging it as-is but more testing is better IMO. ;-)

@srebhan srebhan assigned powersj and unassigned srebhan Sep 21, 2023
@telegraf-tiger
Copy link
Contributor

@powersj powersj merged commit 080f5a2 into influxdata:master Sep 22, 2023
@powersj powersj deleted the fix/13826 branch September 22, 2023 15:40
@github-actions github-actions bot added this to the v1.28.2 milestone Sep 22, 2023
powersj added a commit that referenced this pull request Oct 2, 2023
@powersj powersj restored the fix/13826 branch March 29, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A Metric that is Rejected by Google API Blocks new Metrics from Being Sent
2 participants