-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(outputs.stackdriver): Drop metrics on InvalidArgument gRPC error #13931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @powersj! One question about testing, can we somehow mock an "invalid argument" response by mimicking the GRPC server? I'm fine with merging it as-is but more testing is better IMO. ;-)
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Rather than rely on specific error messages that have in fact changed over time, let's instead drop metrics whenever we get an InvalidArgument gRPC error. These are not retry-able errors and should instead be dropped.
fixes: #13826