Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inputs.smart): Remove parsing error message #13927

Merged
merged 1 commit into from
Sep 18, 2023
Merged

fix(inputs.smart): Remove parsing error message #13927

merged 1 commit into from
Sep 18, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Sep 14, 2023

Rather than error out on a parsing error, ignore the error and continue on parsing other fields. This avoids tossing all the data and not returning any metrics. This is the behavior for other parsing functions and fields throughout the plugin.

fixes: #13926

@powersj
fix(inputs.smart): Remove parsing error message
8eb84e7 
Rather than error out on a parsing error, ignore the error and continue
on parsing other fields. This avoids tossing all the data and not
returning any metrics. This is the behavior for other parsing functions
and fields throughout the plugin.

fixes: influxdata#13926
@telegraf-tiger telegraf-tiger bot added area/smart fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Sep 14, 2023
@powersj powersj mentioned this pull request Sep 14, 2023
Closed
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 14, 2023
@powersj powersj marked this pull request as ready for review September 14, 2023 19:56
srebhan
srebhan reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question from my side...

srebhan
srebhan approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, fine with me then. However, hiding these will also hiding them from us as nobody will notice something is not according to expectations...

@srebhan srebhan merged commit df80446 into influxdata:master Sep 18, 2023
@github-actions github-actions bot added this to the v1.28.2 milestone Sep 18, 2023
powersj added a commit that referenced this pull request Oct 2, 2023
@powersj
fix(inputs.smart): Remove parsing error message (#13927)
c6f80c8 
(cherry picked from commit df80446)
@chenrui333 chenrui333 mentioned this pull request Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
area/smart fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.28.2
Development

Successfully merging this pull request may close these issues.

Generate parsing error for smart field value "<not available>"
2 participants
@powersj @srebhan