Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prometheus): Allow to specify metric type #13874

Merged
merged 5 commits into from
Sep 11, 2023

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Sep 6, 2023

resolves #13844
resolves #13079

This PR allows to explicitly set the metric type for the prometheus serializer and the prometheus_client output plugin. This is required as a large number of plugins will not or cannot type Telegraf metrics but prometheus uses those types.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Sep 6, 2023
@srebhan srebhan added area/prometheus plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins plugin/serializer ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Sep 6, 2023
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice and clean, thank you! One typo I think

Co-authored-by: Joshua Powers <powersj@fastmail.com>
@telegraf-tiger
Copy link
Contributor

@powersj powersj merged commit 84b3b58 into influxdata:master Sep 11, 2023
@github-actions github-actions bot added this to the v1.28.0 milestone Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prometheus feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins plugin/serializer ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
2 participants