Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inputs.redis_sentinel): Allow username and password #13864

Merged
merged 1 commit into from
Sep 11, 2023
Merged

feat(inputs.redis_sentinel): Allow username and password #13864

merged 1 commit into from
Sep 11, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Sep 5, 2023

fixes: #13836

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Sep 5, 2023
@powersj powersj mentioned this pull request Sep 5, 2023
Closed
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Sep 5, 2023

Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 1.01 % for linux amd64 (new size: 197.0 MB, nightly size 195.0 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 7, 2023
@powersj powersj marked this pull request as ready for review September 7, 2023 19:58
srebhan
srebhan approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an optional question. Feel free to merge if you answer it with "no". :-)

@srebhan srebhan merged commit 4a5e3a4 into influxdata:master Sep 11, 2023
@github-actions github-actions bot added this to the v1.28.0 milestone Sep 11, 2023
campbelljlowman
campbelljlowman reviewed Sep 12, 2023
View reviewed changes
plugins/inputs/redis/redis.go
Commands []*RedisCommand `toml:"commands"`
Servers []string `toml:"servers"`
Username string `toml:"username"`
Password string `toml:"passowrd"`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is toml:"passowrd" misspelled?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@campbelljlowman ouch, yes please file an issue please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@campbelljlowman campbelljlowman campbelljlowman left review comments

Assignees

@srebhan srebhan

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.28.0
Development

Successfully merging this pull request may close these issues.

Add Username support for authentication in redis and sentinel input plugin within Telegraf
3 participants
@powersj @srebhan @campbelljlowman