-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(parsers.avro): Handle timestamp format checking correctly #13855
Conversation
bff118e
to
4ab227b
Compare
We might want to dump this one in favor of #13856, which subsumes it (handling the format correctly turned out to be useful for testing that fix). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @athornton! Just one small comment...
I think we should keep this fix in a separate PR as the other PR also changes the behavior of the metric output and that might be controversial...
Updated, test cases changed, review re-requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks @athornton!
I am hesitating hitting merge due to the 386 test failure. Do we really need to increase the timeout or is this branch behind master? Or something else? |
2a9f5a8
to
d73e1b0
Compare
We're not behind master anymore, and the error seems to indicate we really do need longer:
|
I find that hard to believe given all you did was modify a switch statement ;) Looking at master you can see we did not max out the system at all: I'm going to land this and hope this is just something strange with the |
It may well be something strange with lsst-sqre, given that we moved away from CircleCI and probably dropped from a paid tier to their free one (we found GitHub Actions to be a much more pleasant experience). |
resolves #13854
Made check for invalid timestamp format happen outside the if clause that only fired if the format was the empty string.