Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(outputs.postgresql): Add option to rename time column #13750

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Aug 11, 2023

resolves #13744

This PR adds an option to specify the name of the column used for storing the metric timestamp.

@telegraf-tiger telegraf-tiger bot added area/postgresql feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Aug 11, 2023
@jcpunk
Copy link

jcpunk commented Aug 11, 2023

My local testing shows this works for me.

@srebhan srebhan force-pushed the postgres_issue_13744 branch from e330075 to 70fc9cb Compare August 14, 2023 20:06
@telegraf-tiger
Copy link
Contributor

@srebhan srebhan requested a review from phemmer August 14, 2023 20:58
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Aug 14, 2023
@srebhan
Copy link
Member Author

srebhan commented Aug 15, 2023

Fine with @phemmer according to his comment on #13763.

@srebhan srebhan merged commit 17c7c02 into influxdata:master Aug 15, 2023
@srebhan srebhan deleted the postgres_issue_13744 branch August 15, 2023 16:50
@github-actions github-actions bot added this to the v1.28.0 milestone Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/postgresql feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

output/postgresql: Expose time column name as config option
4 participants