-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(serializers.nowmetric): Add option for JSONv2 format #13722
Conversation
The nowmetric serializer by default produces metrics in the Operational Intelligence format. This adds a format object, which can be set to jsonv2 to produce metrics compatable with the JSONv2 endpoint. The primary difference is in the JSON format. The JSONv2 endpoint is based around an object, while the previous OI format is based around a list of metrics.
d9fb445
to
4a00e1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two small comments @powersj...
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
(cherry picked from commit 93bf2be)
The nowmetric serializer by default produces metrics in the Operational
Intelligence format. This adds a format object, which can be set to
jsonv2 to produce metrics compatible with the JSONv2 endpoint.
The primary difference is in the JSON format. The JSONv2 endpoint is
based around an object, while the previous OI format is based around a
list of metrics.