fix(parsers.xpath): Handle protobuf maps correctly #13719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm this parses for my use case. |
powersj
reviewed
Aug 3, 2023
| @@ -138,7 +138,6 @@ func (d *protobufDocument) GetNodePath(node, relativeTo dataNode, sep string) st | |||
| if n.Parent != nil && n.Parent.Value() != nil { | |||
| kind = reflect.TypeOf(n.Parent.Value()).Kind() | |||
| } | |||
| fmt.Printf("node %q: %v (value=%v) parent: %v\n", n.Data, kind, n.Value(), n.Parent.Value()) | |||
There was a problem hiding this comment.
Are these helpful? should they be log messages? Same question in xpath/parsers.go
There was a problem hiding this comment.
I'd love to have those at the debug level.
There was a problem hiding this comment.
These will only pollute the output. If in doubt you can always print the XML equivalent of the input document using the xpath_print_document setting.
21925c1 to
842759b
Compare
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
powersj
approved these changes
Aug 7, 2023
powersj
pushed a commit
that referenced
this pull request
Aug 21, 2023
(cherry picked from commit 806b7cd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #13715
Currently, Telegraf panics if you use maps (such as
map<string, string>) in your protocol-buffers. This is mainly due to a bug in the protocol-buffer parsing code of theprotobufquerylibrary.This PR bumps the dependency of the library and adds a unit-test based on the data of #13715. While at it I unified the location of the xpath-querying libraries under the
srebhanaccount.