-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.cisco_telemetry_mdt): Fix MDT source field overwrite #13693
fix(inputs.cisco_telemetry_mdt): Fix MDT source field overwrite #13693
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this issue @0x2142! One small comment and I think you should add a unit-test to make sure the source is really stored in the intended way.
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @0x2142! Thanks for the fix!
(cherry picked from commit 66dc5ce)
resolves #11920
Incoming Cisco MDT payload may contain
source
key, which is overwritten upon receipt by Telegraf. This update resolves the issue by renaming the incomingsource
key if present. By default, this key will be renamed tomdt_source
- however, there is an option for the user to manually specify a desired name using thesource_field_name
config value.