Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.cisco_telemetry_mdt): Fix MDT source field overwrite #13693

Merged
merged 5 commits into from
Jul 31, 2023
Merged

fix(inputs.cisco_telemetry_mdt): Fix MDT source field overwrite #13693

merged 5 commits into from
Jul 31, 2023

Conversation

0x2142
Copy link
Contributor

@0x2142 0x2142 commented Jul 28, 2023

resolves #11920

Incoming Cisco MDT payload may contain source key, which is overwritten upon receipt by Telegraf. This update resolves the issue by renaming the incoming source key if present. By default, this key will be renamed to mdt_source - however, there is an option for the user to manually specify a desired name using the source_field_name config value.

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this issue @0x2142! One small comment and I think you should add a unit-test to make sure the source is really stored in the intended way.

@srebhan srebhan self-assigned this Jul 28, 2023
@srebhan srebhan added fix pr to fix corresponding bug area/cisco plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jul 28, 2023
@telegraf-tiger
Copy link
Contributor

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 31, 2023
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @0x2142! Thanks for the fix!

@srebhan srebhan merged commit 66dc5ce into influxdata:master Jul 31, 2023
@github-actions github-actions bot added this to the v1.27.4 milestone Jul 31, 2023
@0x2142 0x2142 deleted the fix-cisco-mdt-source-overwrite branch July 31, 2023 20:00
powersj pushed a commit that referenced this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cisco fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cisco model Driven Telemetry plugin source tag issue
3 participants