-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(parsers.xpath): Ensure precedence of explicitly defined tags and fields #13662
fix(parsers.xpath): Ensure precedence of explicitly defined tags and fields #13662
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me
9920f77
to
fb6bc2b
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little concerned about regressions and/or corner cases that our previous tests do not cover, but this does seem to clean up the behavior.
based on #13660
This PR ensures that explicitly defined tags and fields will override their batch-counterparts if a tag or field name is reused. This can be helpful in case you want to type-convert only one field out of many (potentially unknown ones) and thus need to override only one field value.