Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.prometheus): don't collect metrics from finished pods #13629

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

redbaron
Copy link
Contributor

Required for all PRs

resolves #13393

@telegraf-tiger
Copy link
Contributor

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 17, 2023
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @redbaron!

@srebhan srebhan added area/prometheus fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jul 21, 2023
@srebhan srebhan merged commit 9d894e7 into influxdata:master Jul 21, 2023
@github-actions github-actions bot added this to the v1.27.3 milestone Jul 21, 2023
@redbaron redbaron deleted the prometheus-pod-running branch July 21, 2023 09:43
powersj pushed a commit that referenced this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prometheus fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[inputs.prometheus] Only scrape really running pods by also checking Pod.Status.Phase
3 participants